feat(Drive): Show loader when opening a file from conversation (WPB-28575) by ohassine · Pull Request #5262 · wireapp/wire-android

ohassine · 2026-09-08T13:59:41Z

https://wearezeta.atlassian.net/browse/WPB-28575

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Display a loading indicator when the user opens a file from a conversation while the file is being loaded.

Screen_recording_20260908_155805.mp4

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

# Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt

…oading-behavior

…le-offline # Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFileActionsMenu.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFileLocalPathCache.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellListItem.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesWithSlideInTransitionScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/OpenFileDownloadController.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/model/CellNodeUi.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/model/NodeBottomSheetAction.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/model/OpenLoadState.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/search/SearchScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/util/FileHelper.kt # features/cells/src/main/res/values/strings.xml # features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/CellFileActionsMenuTest.kt # features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/CellViewModelTest.kt # features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/OpenFileDownloadControllerTest.kt # kalium

…le-offline # Conflicts: # kalium

…to display-offline-files # Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/model/CellNodeUi.kt # kalium

…to display-offline-files

…onversation # Conflicts: # kalium

…onversation # Conflicts: # app/src/main/kotlin/com/wire/android/di/accountScoped/CellsModule.kt # app/src/main/kotlin/com/wire/android/ui/common/multipart/MultipartAttachmentUi.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/multipart/MultipartAttachmentsView.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/multipart/MultipartAttachmentsViewModel.kt # app/src/test/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/multipart/MultipartAttachmentsViewModelTest.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/AllFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFileActionsMenu.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFileLocalPathCache.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/OfflineFileDownloadController.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/OpenFileDownloadController.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/model/CellNodeUi.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/search/SearchScreen.kt # features/cells/src/main/res/values/strings.xml # features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/CellFileActionsMenuTest.kt # features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/CellViewModelTest.kt # kalium

…onversation # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/multipart/MultipartAttachmentsViewModel.kt

…onversation # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationCoreViewModelFactory.kt # app/src/main/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/multipart/MultipartAttachmentsViewModel.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/search/SearchScreen.kt

github-actions · 2026-09-08T14:12:13Z

Test Results

542 tests - 2 139 542 ✅ - 2 139 41s ⏱️ - 1m 12s
60 suites - 278 0 💤 ± 0
60 files - 278 0 ❌ ± 0

Results for commit 5299e16. ± Comparison against base commit 4e4a6d1.

This pull request removes 2139 tests.

com.wire.android.GlobalObserversManagerTest ‑ given app not visible and valid session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app not visible and valid session, when observing app open, then do not retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and invalid session, when app opens, then do not retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and invalid session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and no session, when app opens, then do not retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and no session, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and session failure, when app opens, then do not retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and session failure, when handling ephemeral messages, then do not call deleteEphemeralMessageEndDate()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and valid session, when app opens, then retry sending pending messages()
com.wire.android.GlobalObserversManagerTest ‑ given app visible and valid session, when handling ephemeral messages, then call deleteEphemeralMessageEndDate()
…

♻️ This comment has been updated with latest results.

ohassine added 30 commits April 23, 2026 18:56

feat: new loading behavior

3b353bd

Merge remote-tracking branch 'origin/develop' into new-loading-behavior

6704b01

Merge remote-tracking branch 'origin/develop' into new-loading-behavior

5d97f06

feat: remove download to external storage option

43c0418

feat: cleanup

9ea06e7

feat: detekt

fa81683

Merge remote-tracking branch 'origin/develop' into new-loading-behavior

dcf676f

Merge remote-tracking branch 'origin/develop' into new-loading-behavior

ca33415

# Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt

feat: cleanup

ff7f3b5

feat: cleanup

8d57c00

feat: cleanup

5296036

fix: cleanup

add26ee

fix: cleanup

942a6e2

feat: refactor

a9e6d8c

feat: unit test

2bb96f2

Merge branch 'develop' into new-loading-behavior

d403848

feat: detekt

771b73d

Merge remote-tracking branch 'origin/new-loading-behavior' into new-l…

3f458b1

…oading-behavior

feat: detekt

784c3d3

Merge branch 'develop' into new-loading-behavior

24a0eea

Merge branch 'develop' into new-loading-behavior

f8a0d11

chore: test

d76da05

Merge branch 'develop' into new-loading-behavior

1a25574

feat(drive): Make files available offline

defa808

feat(drive): Make files available offline

ed03ad9

Merge remote-tracking branch 'origin/develop' into Make-files-availab…

e45ce22

…le-offline # Conflicts: # kalium

chore: cleanup

e629614

chore: cleanup

a6852d9

chore: detekt

5db198b

ohassine added 25 commits May 13, 2026 13:33

chore: add conversationId

065917d

chore: add conversationId

bea8de1

chore: kalium reference

9cc0b51

chore: test

b9cdfef

chore: detekt

e4aadf2

Merge branch 'develop' into Make-files-available-offline

3cc3b57

Merge remote-tracking branch 'origin/Make-files-available-offline' in…

155c2d1

…to display-offline-files # Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/model/CellNodeUi.kt # kalium

Merge branch 'Make-files-available-offline' into display-offline-files

0d26300

chore: detekt

3965331

chore: kalium

6125be1

chore: test

27f686e

Merge branch 'Make-files-available-offline' into display-offline-files

e44bd6f

chore: test

d4c75c1

chore: detekt

8c63ab4

Merge remote-tracking branch 'origin/Make-files-available-offline' in…

c69e635

…to display-offline-files

chore: cleanup

92c9caa

refactor: add mimeType

7bedbad

feat: show offline indicator for files in conversation

dffb611

feat: loading files in conversation

702224a

Merge remote-tracking branch 'origin/develop' into loading-files-in-c…

4e3811f

…onversation # Conflicts: # kalium

feat: load video

8f6fe1a

Merge remote-tracking branch 'origin/develop' into loading-files-in-c…

8724f4d

…onversation # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/model/messagetypes/multipart/MultipartAttachmentsViewModel.kt

chore: cleanup

1f587f3

pull-request-size Bot added the size/L label Sep 8, 2026

github-actions Bot assigned ohassine Sep 8, 2026

ohassine added 2 commits September 8, 2026 16:18

chore: detekt

7d6f7ba

chore: detekt

5299e16

Navigation Menu

Uh oh!

feat(Drive): Show loader when opening a file from conversation (WPB-28575) - #5262

feat(Drive): Show loader when opening a file from conversation (WPB-28575)#5262
ohassine wants to merge 86 commits into
developfrom
loading-files-in-conversation

ohassine commented Sep 8, 2026 •

edited by github-actions Bot

Loading

Uh oh!

github-actions Bot commented Sep 8, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

ohassine commented Sep 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Dependencies (Optional)

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

Uh oh!

github-actions Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ohassine commented Sep 8, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Sep 8, 2026 •

edited

Loading